Remove deprecated PAC aliases #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were deprecated in v0.6.0 so we can remove them now. I'm not sure when its appropriate to do so though.
crates.io statistics says we still have plenty of 0.5.3 downloads, so those people would never see the deprecation warning.
On the other hand, having 3 aliases for the same thing makes the docs.rs search quite a lot more cluttered (see below) so getting rid of it soon would be nice.
Is it possible to do a "hard deprecation" where we export an empty module that gives a clear error message
used? That would fix the docs.rs breakage