extend ticks calculation in timer start from u32 to u64 #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apatrushev
force-pushed
the
fix-timer-342
branch
from
206276e to
6955374
Compare
apatrushev
force-pushed
the
fix-timer-342
branch
from
6955374 to
7228f08
Compare
Sh3Rm4n
requested changes
Nov 23, 2023
| @@ -279,9 +279,9 @@ where | |||
| let timeout: Self::Time = timeout.into(); | |||
| let clock = TIM::clock(&self.clocks); | |||
|
|
|||
| let ticks = clock.integer().saturating_mul(timeout.integer()) * *timeout.scaling_factor(); | |||
| let ticks = (clock.integer() as u64).saturating_mul(timeout.integer() as u64) * *timeout.scaling_factor(); | |||
There was a problem hiding this comment.
This is definitely a good improvement, please use u64::from instead of as casts :)
Suggested change
| let ticks = (clock.integer() as u64).saturating_mul(timeout.integer() as u64) * *timeout.scaling_factor(); | |
| let ticks = u64::from(clock.integer()).saturating_mul(u64::from(timeout.integer()) * *timeout.scaling_factor(); |
Sh3Rm4n
added a commit
that referenced
this pull request
Nov 28, 2023
|
Thanks, I've rebased and merged it in #356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #342