Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is PinState no longer used from embedded-hal in 0.11? #414

Closed
birkenfeld opened this issue Jan 8, 2022 · 4 comments
Closed

Why is PinState no longer used from embedded-hal in 0.11? #414

birkenfeld opened this issue Jan 8, 2022 · 4 comments

Comments

@birkenfeld
Copy link
Contributor

This seems like a regression; the two types look identical.
@burrbull
Copy link
Contributor

burrbull commented Jan 8, 2022

It was preparing for #388. Is it breaking?

@birkenfeld
Copy link
Contributor Author

It breaks when updating, but that's ok. The reason I was wondering is that it seemed strange that common definitions from hal were repeated in this crate.

@burrbull
Copy link
Contributor

#428

@birkenfeld
Copy link
Contributor Author

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@birkenfeld @burrbull