Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPI Slave mode #483

Closed
Arnaud078 opened this issue Apr 18, 2022 · 3 comments
Closed

SPI Slave mode #483

Arnaud078 opened this issue Apr 18, 2022 · 3 comments

Comments

@Arnaud078
Copy link
Contributor

Hello,

I am working on a project which requires a Raspberry Pi to communicate with a stm32f411. I was thinking of using SPI with the Raspberry as the master. As of now, neither this crate nor the embedded-hal seem to provide this feature. I have forked this repo and implemented a working solution here : https://github.com/Arnaud078/stm32f4xx-hal/commit/4b4baa5ebee1a5b8b0553fbe93ad7343efe0b4d0

I am new to rust, open source and this repo, so I am wondering if that looks good enough for a PR or is there more work to be done ? Is there a cleaner way to achieve SPI slave mode ?

Rgds,
Arnaud
@burrbull
Copy link
Member

If you have ideas with working code you are free to make PR.
It's better to discuss it there.
In first view your code looks good.

@burrbull
Copy link
Member

stm32-rs/stm32f1xx-hal#408

@Arnaud078 Arnaud078 mentioned this issue Apr 23, 2022
Merged
bors bot added a commit that referenced this issue Apr 24, 2022
@bors @Arnaud078
Merge #487
84ef991 
487: adding spi slave r=burrbull a=Arnaud078

as mentionned in issue #483

Co-authored-by: Arnaud <arnaud078@gmail.com>
@Arnaud078
Copy link
Contributor Author

solved by #487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Arnaud078 @burrbull