DMA: Support both WriteBuffer and ReadBuffer #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you resolve the conflict? I guess I'm ready to dive into this new adventure now... 😅 |
|
I really want to reduce monomophirzation in the DMA code, but I guess it's better to leave that for another PR, gonna resolve the changelog conflicts now |
- Memory to peripheral transfers now only require read access to the buffer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory to peripheral transfers now only require read access to the buffer
I tried to reduce code duplication, but some of it is necessary. This removes a big constrain on memory-to-peripheral transfers.
Draft because I need to look at some stuff and do some testing.