Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DMA with the ADC wrapper. #258

Merged
merged 2 commits into from
Apr 18, 2021
Merged

Conversation

matoushybl
Copy link
Contributor

Implements the PeriAddress trait for Adc, making it possible for it to be used with the Transfer DMA implementation.

Fixes a rounding problem in the temperature equation.
Fixes temperature sensor channel assignment for F405. The problem seems to affect all of the F40x and the F41x as the reference manual claims that the channel is 16 instead of 18.

@matoushybl
Copy link
Contributor Author

Hi!
I've added an example of using ADC with RTIC and DMA and rebased the PR.
Would it please be possible to review and merge this?

Thanks!
CC: @therealprof @thalesfragoso

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@therealprof
Copy link
Member

bors r+

@bors bors bot merged commit fc9c650 into stm32-rs:master Apr 18, 2021
@matoushybl
Copy link
Contributor Author

Thanks for the review! I've just created a patch that removes the need for the unsafe code, I'll open a new PR with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants