RCC for F412, F413, F423, F446: Add missing configuration of PLLI2SCFGR.PLLI2SN #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therealprof
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing I2S on an STM32F412, I found that the clock setup code was not correctly configuring the I2S PLL. The clock setup code found a good configuration, but did not write it correctly to the PLL configuration register. The PLLI2SCFGR.PLLI2SN field was left at its default value.
This pull request changes one function to write PLLI2SCFGR.PLLI2SN when applying a PLL configuration.
The updated code is working well for I2S on my STM32F412. I don't have an F413, F423, or F446 to test with, but this seems like a simple fix that is unlikely to break other code.