CAN: Add more pins, support CAN for more models, add CAN3 where available #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matoushybl
reviewed
Feb 6, 2021
|
LGTM, thanks for the PR! |
thalesfragoso
approved these changes
Feb 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked through all the STM32F4 datasheets to find additional pins that can be used for CAN, and added implementations of the
can::Pinstrait for those pins. As part of the process, I enabled thecanmodule for several STM32F4 models that support CAN beyond the F405, F407, and F446. I also added CAN3 and the associated pins for F413 and F423 models.This also includes some small documentation improvements that I thought might be helpful.
I'm not sure if this needs a changelog entry because it's in the same version where CAN support was first added. I added one anyway to make the automated checks happy.