Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation of rng and prelude #303

Merged
merged 4 commits into from
Jun 21, 2021
Merged

Conversation

jounathaen
Copy link
Contributor

@jounathaen jounathaen commented Apr 20, 2021

This adds doc comments to the rng and prelude module as well as to the re-export of the svd2rust API.

The rng documentation might repeat some information, but as the generated documentation splits this to multiple pages, I find it is better that way. I also added small example code to the documentation. The examples in the repository are nice, but I personally would favor examples inside the docs.

It might be good, if somebody reads over the prelude part to check that I'm not completely off-track there.

@jounathaen
Copy link
Contributor Author

Ok, apparently a changelog entry is missing. Is this necessary in this case?

@therealprof
Copy link
Member

Ok, apparently a changelog entry is missing. Is this necessary in this case?

Why not? Improved documentation is noteworthy.

@jounathaen
Copy link
Contributor Author

Ok, from my side this is ready for review.
I hope this is acceptable and helps somebody. Thank you all for your work on this project!
🙂

@burrbull
Copy link
Member

Rebase, please.

@jounathaen
Copy link
Contributor Author

Rebased!

@burrbull
Copy link
Member

bors r+

@bors bors bot merged commit 9f457f2 into stm32-rs:master Jun 21, 2021
@jounathaen jounathaen deleted the better_doc branch June 21, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants