Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rcc Enable/Reset + features #311

Merged
merged 3 commits into from
Jun 20, 2021
Merged

Rcc Enable/Reset + features #311

merged 3 commits into from
Jun 20, 2021

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull force-pushed the rcc branch 2 times, most recently from 967dc3c to 29d1fcd Compare May 24, 2021 13:18
@burrbull burrbull changed the title rcc rework + features Rcc Enable/Reset + features May 24, 2021
@thalesfragoso
Copy link
Member

Hmm, seems like you're removing bit banding, but still not requiring the user to pass in the RCC, and then using modify which might cause races, if we want to go ahead with this we might want to use a critical section or change the traits implementations to use bit banding.

@burrbull
Copy link
Member Author

Hmm, seems like you're removing bit banding, but still not requiring the user to pass in the RCC, and then using modify which might cause races, if we want to go ahead with this we might want to use a critical section or change the traits implementations to use bit banding.

Revert bit-banding. See last commit.

thalesfragoso
thalesfragoso requested changes Jun 20, 2021
View reviewed changes
Copy link
Member

@thalesfragoso thalesfragoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really outstanding work, I just noticed a few small problems, but thank you!

src/pwm.rs Outdated Show resolved Hide resolved
src/rtc.rs Outdated Show resolved Hide resolved
src/rtc.rs Outdated Show resolved Hide resolved
thalesfragoso
thalesfragoso approved these changes Jun 20, 2021
View reviewed changes
Copy link
Member

@thalesfragoso thalesfragoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@thalesfragoso
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 20, 2021

Build succeeded:

@bors bors bot merged commit 8a89078 into master Jun 20, 2021
@bors bors bot deleted the rcc branch June 20, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesfragoso thalesfragoso thalesfragoso approved these changes

Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @thalesfragoso