Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds missing dma error flags #318

Merged
merged 1 commit into from
Jun 19, 2021
Merged

adds missing dma error flags #318

merged 1 commit into from
Jun 19, 2021

Conversation

peauters
Copy link
Contributor

This PR adds the missing methods to retrieve the error flags for dma streams.

burrbull
burrbull previously approved these changes Jun 18, 2021
View reviewed changes
@peauters peauters mentioned this pull request Jun 18, 2021
Merged
therealprof
therealprof approved these changes Jun 19, 2021
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too. Thanks.

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 19, 2021

Build succeeded:

@bors bors bot merged commit 3c8e308 into stm32-rs:master Jun 19, 2021
@peauters peauters deleted the dma-interrupt-flags branch June 19, 2021 12:47
@peauters
Copy link
Contributor Author

Thanks!

bors bot added a commit that referenced this pull request Nov 18, 2021
@bors @peauters
Merge #319
b3aab7d 
319: adds dma support for spi r=burrbull a=peauters

This is a first draft of what DMA support for SPI would look like.

I don't have a great opinion on how some of the error flags can/should be used in conjunction with DMA transfers and would love some advice.

Once #318 has been merged, I'll update the example to look at the extra error flags to show multiple transfers.

Co-authored-by: peauters <40306785+peauters@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@burrbull burrbull burrbull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peauters @burrbull @therealprof