Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timer rework #337

Merged
merged 8 commits into from
Jul 10, 2021
Merged

Timer rework #337

merged 8 commits into from
Jul 10, 2021

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Jul 7, 2021

No description provided.

@burrbull burrbull force-pushed the timer branch 2 times, most recently from 19015f5 to f6f77da Compare July 7, 2021 19:30
@burrbull burrbull marked this pull request as ready for review July 8, 2021 03:36
@burrbull burrbull mentioned this pull request Jul 8, 2021
Merged
5 tasks
therealprof
therealprof reviewed Jul 10, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
therealprof
therealprof previously approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Found one nit and will likely need a rebase after the other PR is merged.

therealprof
therealprof approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 10, 2021

Build succeeded:

@bors bors bot merged commit f05b81e into master Jul 10, 2021
@bors bors bot deleted the timer branch July 10, 2021 16:06
bors bot added a commit that referenced this pull request Jul 15, 2021
@bors @theunkn0wn1
Merge #271
657b265 
271: PWM Input abstraction r=burrbull a=theunkn0wn1



It also presently depends on side effects, due to my limited experience writing at the HAL layer.
There is also one unsafe block when configuring the prescalers, as it seems (or my IDE is failing me) that the prescaler's don't have safe abstractions for configuring them.

Thnkgs that need be done:
 - [x] get it working for one MCU
 - [x] use macros to generate the definition
 - [x] get it working with all compatible timers across all compatible f4 devices
 - [x] configure the timer's frequency internally instead of depending on side effects
Feedback and suggestions are welcome.
- [x] rework as per #337

Co-authored-by: Joshua Salzedo <joshuasalzedo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @therealprof