Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoPin & no Pins #340

Merged
merged 2 commits into from
Jul 15, 2021
Merged

NoPin & no Pins #340

merged 2 commits into from
Jul 15, 2021

Conversation

burrbull
Copy link
Contributor

One NoPin type and NoTx, `NoSck etc. are aliases for it.

Use (TX, RX) directly in constructors instead of Pins. Better for docs:
изображение

vs

изображение

@burrbull burrbull force-pushed the serial3 branch 2 times, most recently from 1a01573 to 5d2eb3a Compare July 11, 2021 03:05
thalesfragoso
thalesfragoso approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@thalesfragoso thalesfragoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, doing a great work, thank you!

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 15, 2021

Build succeeded:

@bors bors bot merged commit 9775f61 into master Jul 15, 2021
@burrbull burrbull deleted the serial3 branch August 4, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thalesfragoso thalesfragoso thalesfragoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @thalesfragoso