Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change rtic-tick example system clock to fix assert. #390

Merged
merged 1 commit into from
Nov 21, 2021

Conversation

linuxtim
Copy link

The rtic-tick example asserts during clock setup because the code attempts to configure a clock of 8 MHz, which is below the lowest SYSCLK_MIN defined in src/rcc/mod.rs (12.5 MHz). Change requested clock to 48 MHz (above the highest SYSCLK_MIN of 24 MHz).

@linuxtim linuxtim changed the title Configure rtic-tick example system clock to fix assert. Change rtic-tick example system clock to fix assert. Nov 20, 2021
@linuxtim linuxtim force-pushed the fix-rtic-tick-example-sysclock branch from 912ad44 to 258c525 Compare November 20, 2021 20:18
@burrbull
Copy link
Contributor

Add link on PR to changelog:

- Implementation of RTIC Monotonic for TIM2 & TIM5 under `rtic` feature [#380]

Increase sysclk above SYSCLK_MIN, so that the example doesn't panic
during init.
@linuxtim linuxtim force-pushed the fix-rtic-tick-example-sysclock branch from 258c525 to fac1ebf Compare November 21, 2021 11:06
@linuxtim
Copy link
Author

Add link on PR to changelog

My thought was that since the fixed code was unreleased, the additional noise it would generate wouldn't justify a changelog entry. I've pushed a minimal change. Please feel free to edit the revised commit if it's unsatisfactory.

@burrbull
Copy link
Contributor

bors r+

@bors bors bot merged commit 7ac6eff into stm32-rs:master Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants