fix #362: ADC voltage conversion might be incorrect #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gernoteger
force-pushed
the
fix_adc_voltage
branch
from
fdb5711
to
9f4d8d7
Compare
|
Maybe add some description about convertion rules in |
|
Ok, will do that |
jordens
previously approved these changes
Dec 8, 2021
There was a problem hiding this comment.
Thanks!
This makes the Debug::fmt() output a bit confusing as now that max_sample is exclusive. But it says nowhere that max_sample must be inclusive so I'm absolutely fine with it. Maybe a small comment in on the struct field would help though.
|
@jordens Sorry, I don't understand the comment about Debug::fmt(), this PR doesn't change anything there. Sure you commented on the right PR? |
|
The PR does affects the string that it printed. It would now say e.g. |
|
Thanks, now I get it. Since docs are an open task, I'll consider that.
|
gernoteger
force-pushed
the
fix_adc_voltage
branch
from
dc5b856
to
d9a9cd2
Compare
burrbull
approved these changes
Dec 11, 2021
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since the discussion in #362 seems to come to a conclusion, and my personal measurements supported that, I think it's time to actually fix it.
This will change max_sample from 1<<n-1 to 1<<n,
After this PR ADC readings will change, but will be more accurate than before. Users might be confused since they won't get a reading of 3300mV, but this is correct behaviour.