Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use RTIC 1.0, fix warnings #401

Merged
merged 1 commit into from
Dec 27, 2021
Merged

use RTIC 1.0, fix warnings #401

merged 1 commit into from
Dec 27, 2021

Conversation

burrbull
Copy link
Member

No description provided.

@burrbull burrbull changed the title use RTIC 1.0, fix warnings use RTIC 1.0, edition 2021, fix warnings Dec 25, 2021
therealprof
therealprof requested changes Dec 25, 2021
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moving to Edition 2021 is maybe a bit too early. I don't see the pressing need to limit the possible Rust compilers just yet. If we really want to go there now we should do another edition 2018 release first.

@burrbull burrbull changed the title use RTIC 1.0, edition 2021, fix warnings use RTIC 1.0, fix warnings Dec 26, 2021
@burrbull
Copy link
Member Author

I think moving to Edition 2021 is maybe a bit too early. I don't see the pressing need to limit the possible Rust compilers just yet. If we really want to go there now we should do another edition 2018 release first.

Ok. Resonable. Reversed

therealprof
therealprof previously approved these changes Dec 26, 2021
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@burrbull
Copy link
Member Author

bors r=therealprof

bors bot added a commit that referenced this pull request Dec 26, 2021
@bors @burrbull
Merge #401
b2a738c 
401: use RTIC 1.0, fix warnings r=therealprof a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 26, 2021

Build failed:

@burrbull
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Dec 26, 2021
@bors @burrbull
Merge #401
6cd7038 
401: use RTIC 1.0, fix warnings r=therealprof a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 26, 2021

Build failed:

@burrbull
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Dec 26, 2021
@bors @burrbull
Merge #401
d0854e8 
401: use RTIC 1.0, fix warnings r=therealprof a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 26, 2021

Timed out.

@burrbull
Copy link
Member Author

Four tries and each time 1 of tasks freezes.

@burrbull
Copy link
Member Author

bors retry

@burrbull
Copy link
Member Author

bors r=therealprof

bors bot added a commit that referenced this pull request Dec 27, 2021
@bors @burrbull
Merge #401
a660cf5 
401: use RTIC 1.0, fix warnings r=therealprof a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Dec 27, 2021

Build failed:

@therealprof
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 27, 2021

👎 Rejected by too few approved reviews

therealprof
therealprof approved these changes Dec 27, 2021
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Dec 27, 2021
@bors @burrbull
Merge #401
62140e1 
401: use RTIC 1.0, fix warnings r=therealprof a=burrbull



Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@therealprof
Copy link
Member

Four tries and each time 1 of tasks freezes.

Seems GH is having weird issues...

@bors
Copy link
Contributor

bors bot commented Dec 27, 2021

Build failed:

  • ci (stm32f411, stable)
  • ci (stm32f417, stable)

@therealprof therealprof merged commit 94b20d3 into master Dec 27, 2021
@bors bors bot deleted the fix branch December 27, 2021 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @therealprof