Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serial Tx, Rx containing pins #514

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Serial Tx, Rx containing pins #514

merged 1 commit into from
Aug 15, 2022

Conversation

burrbull
Copy link
Contributor

Related to #505

Instead of changing API I added alternative.

So now to can choose between Tx, Rx with erased information about pins and UTx, URx which can join to restore Serial

burrbull
burrbull commented Aug 15, 2022
View reviewed changes
src/serial.rs Show resolved Hide resolved
therealprof
therealprof approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

bors r+

bors bot added a commit that referenced this pull request Aug 15, 2022
@bors @burrbull
Merge #514
1e1c59c 
514: Serial Tx, Rx containing pins r=therealprof a=burrbull

Related to #505 

Instead of changing API I added alternative.

So now to can choose between `Tx`, `Rx` with erased information about pins and `UTx`, `URx` which can join to restore `Serial`

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 15, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"All comments must be resolved.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@burrbull
Copy link
Contributor Author

bors retry

@bors
Copy link
Contributor

bors bot commented Aug 15, 2022

Build succeeded:

@bors bors bot merged commit 1e12e92 into master Aug 15, 2022
@bors bors bot deleted the nondestructive branch August 15, 2022 11:02
@burrbull burrbull mentioned this pull request Aug 15, 2022
Merged
bors bot added a commit that referenced this pull request Aug 16, 2022
@bors @burrbull
Merge #515
12b5bc1 
515: Deref for UTx, URx r=therealprof a=burrbull

Removes boilerplate from #514

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
@burrbull burrbull mentioned this pull request Oct 18, 2022
Merged
bors bot added a commit that referenced this pull request Oct 18, 2022
@bors @burrbull
Merge #541
99b34a0 
541: fix removed Tx::Write<u8> r=therealprof a=burrbull

Fix #528 .
Restore implementation accidentally removed in #514

Co-authored-by: Andrey Zgarbul <zgarbul.andrey@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @therealprof