Dual i2s core #637
Dual i2s core #637
Conversation
|
looks good for me |
|
I ask that because i'd like to have a similar style to the single i2s, but the current implementation feel weird, espacially if i want to implement the equivalent of I2sExt. Anyway, i can't change it later. At the moment i just need a way to test stuff in stm32_i2s crate |
|
I, can i have a comment about this work ? should I rebase ? |
Yes, rebase, please. |
|
After rebase you can remove speed workaround: |
YruamaLairba
force-pushed
the
dual_i2s_core
branch
from
101b8e8
to
5583ff8
Compare
|
rebased! @burrbull: sorry, i didn't understood if you plan to apply your patch yourself ? in this case i don't need to do anything, but please comment why you are changing pin speed. |
|
Too many commits. Squash, please |
Extension trait for SPI I2SEXT association + duali2s struct DulaI2S ctor and dtor dual i2s: access to ws pin and i2s clock macro to implment DualI2sPeripheral remove a clippy lint fix the dual_i2s macro and use it fix EXT_REGISTERS apply workaround for corrupted last bit of data fix an odd condition add rtic example with dual i2s driver replace Extension trait by DualInstance trait add DualI2sExt trait stm32_i2s v0.5.0 have been published require features for rtic-dual-i2s-audio-in-out example fix formatting disable DualI2s implmentation for 412/423 to workaround missing I2SEXT udpate CHANGELOG
YruamaLairba
force-pushed
the
dual_i2s_core
branch
from
5c5b32d
to
f3b0f96
Compare
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
Hi, i'm trying to implement the 'device' that is suitable for full duplex i2s communication. I'd like to have opinion about implementation, i'm not sure it follow the general style of the crate. I don't have example to follow, I'm in a unusual situation where the 'device' is composed by 2 peripherals.