Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap embedded-hals #720

Merged
merged 2 commits into from
Jan 10, 2024
Merged

swap embedded-hals #720

merged 2 commits into from
Jan 10, 2024

Conversation

burrbull
Copy link
Member

No description provided.

rursprung
rursprung reviewed Dec 29, 2023
View reviewed changes
Copy link
Contributor

@rursprung rursprung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: i just noticed that the UART-related e-h 1.0 traits (which aren't in e-h but in embedded-io) are not yet implemented here. i've raised #721 for this

src/gpio/hal_02.rs Outdated Show resolved Hide resolved
src/prelude.rs Show resolved Hide resolved
@burrbull burrbull force-pushed the ehal-swap branch 2 times, most recently from b394b4c to f1f78e9 Compare December 29, 2023 14:25
@burrbull
Copy link
Member Author

FYI: i just noticed that the UART-related e-h 1.0 traits (which aren't in e-h but in embedded-io) are not yet implemented here. i've raised #721 for this

Yes. There is a lot of traits not implemented yet.
Please open independent PR, if you have a draft.

@burrbull burrbull marked this pull request as ready for review January 10, 2024 04:35
therealprof
therealprof approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@therealprof therealprof added this pull request to the merge queue Jan 10, 2024
Merged via the queue into master with commit 1c41a58 Jan 10, 2024
24 checks passed
@burrbull burrbull deleted the ehal-swap branch January 13, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rursprung rursprung rursprung left review comments

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burrbull @therealprof @rursprung