Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UART::steal & Deref #768

Merged
merged 2 commits into from
Jul 16, 2024
Merged

UART::steal & Deref #768

merged 2 commits into from
Jul 16, 2024

Conversation

burrbull
Copy link
Contributor

No description provided.

@burrbull burrbull force-pushed the uart-steal branch 3 times, most recently from 2737f30 to 0a088e2 Compare June 16, 2024 19:16
therealprof
therealprof reviewed Jun 30, 2024
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit weird to have separate {rx|tx}_peri_address methods when there really is only one data register which is used for both. Even more weird that we do it for UART and I2C but not SPI... Any reason for that?

@burrbull
Copy link
Contributor Author

burrbull commented Jul 1, 2024

It's a bit weird to have separate {rx|tx}_peri_address methods when there really is only one data register which is used for both. Even more weird that we do it for UART and I2C but not SPI... Any reason for that?

I'm still sometimes working on possibility to integrate other families (which have separate registers for RX and TX), so I'm trying to eliminate inconsistencies to simplify code sharing.
Added for SPI too.

therealprof
therealprof approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof therealprof added this pull request to the merge queue Jul 16, 2024
Merged via the queue into master with commit 2ad56a7 Jul 16, 2024
22 checks passed
@burrbull burrbull deleted the uart-steal branch July 27, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burrbull @therealprof