Skip to content

Conversation

rtvd
Copy link
Contributor

@rtvd rtvd commented Oct 27, 2023

Pin definitions for UART8 were missing.

Also, as pins were grouped by type rather than by UART it was not easy to match their definitions to the datasheet.
The change was done in two steps: first I have re-arranged the definitions of pins and grouped them by UART (on the high level) and then by their location in the datasheet, then I have added the pins of UART8.

@rtvd
Copy link
Contributor Author

rtvd commented Oct 31, 2023

@maximeborges please could you take a look? I hope it is not too awful.

@maximeborges
Copy link
Member

I would prefer to group the pins by UART and then by type instead of having them by UART and then by "pair", since there is no concept of RX/TX pins pair AFAIK, i.e.:

// USART1
impl PinTx<USART1> for gpio::PA9<Alternate<7>> {}
impl PinTx<USART1> for gpio::PB6<Alternate<7>> {}

impl PinRx<USART1> for gpio::PA10<Alternate<7>> {}
impl PinRx<USART1> for gpio::PB7<Alternate<7>> {}

instead of:

// USART1
impl PinTx<USART1> for gpio::PA9<Alternate<7>> {}
impl PinRx<USART1> for gpio::PA10<Alternate<7>> {}

impl PinTx<USART1> for gpio::PB6<Alternate<7>> {}
impl PinRx<USART1> for gpio::PB7<Alternate<7>> {}

@rtvd rtvd force-pushed the 2023-10-27--add-uart8-and-rearrange branch from 6e7f6cc to 96cd00d Compare November 5, 2023 09:24
@rtvd
Copy link
Contributor Author

rtvd commented Nov 5, 2023

OK. Updated.

@maximeborges maximeborges merged commit 08e313a into stm32-rs:main Nov 5, 2023
@rtvd rtvd deleted the 2023-10-27--add-uart8-and-rearrange branch November 7, 2023 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants