Support for PWM #29
Merged
Support for PWM #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new version of the stm32g4 crate has been merged, does that resolve your problems regarding this PR? |
This commit requires a recent git version of stm32g4 to compile, as the last released version specifies some wrong register sizes and types. The changes to the code include: - stm32g4xx-hal uses a different API for clock gating/reset. - stm32g4 is missing many bit/field names, so the code often uses .bits() or .set_bit()/.clear_bit() instead. - The advanced-control timers of the STM32G4 MCUs provide four complementary outputs.
|
Yes, it does. This is probably ready to be reviewed. |
This was referenced Dec 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PWM. I took the code from stm32h7xx-hal as the basis as it seemed to provide the most complete implementation for the various timers. The changes include:
or .set_bit()/.clear_bit() instead.
complementary outputs.
This PR requires a recent git version of stm32g4 as the last released version contains some wrong register sizes and types. Therefore, this PR cannot be merged as-is.
I tested a single PWM as shown in the example. The oscilloscope showed the correct duty cycle and period. I did not test advanced features such as deadtime insertion or complementary outputs. I will conduct a test with multiple PWM outputs later.