Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI config and fix formatting and cleanup chip features #7

Merged
merged 2 commits into from
Jan 30, 2021

Conversation

pawelchcki
Copy link
Contributor

@pawelchcki pawelchcki commented Jan 29, 2021

Hi I've copied the CI configuration from stm32-rs/stm32g0xx-hal and updated it to use thumbv7em-none-eabihf target and test all chip features found in the source code.

  • reformated the source to make cargo fmt pass
  • reordered the features alphabetically
  • removed Cargo.lock

@@ -2,15 +2,24 @@
#![allow(non_camel_case_types)]

#[cfg(not(any(
feature = "stm32g431",
feature = "stm32g441",
feature = "stm32g491",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to remove stm32g491 as I couldn't find the feature in stm32g4 crate.

@pawelchcki
Copy link
Contributor Author

Created test PR in my fork, all seems green.

https://github.com/unresc/stm32g4xx-hal/pull/2/checks

@pawelchcki
Copy link
Contributor Author

Also pushed removal Cargo.lock since I think it shouldn't be needed for a library and it was annoying me a bit in my other branches :)

@dotcypress Hey, sorry for pinging you directly again - @summner is my alt account I use for odd stuff, using my main here since I plan to push a few more patches.

I took the liberty to add the CI since its a nice to have safety net.

I know this crate is a bit abandoned, and don't want to ping you all the time :D - are there other people who have merge rights (but maybe don't have notifications set up ?)

Thanks in advance! :)

@dotcypress
Copy link
Member

This is great, thank you!

@dotcypress dotcypress merged commit 6f45bf6 into stm32-rs:master Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants