Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFSDM #79

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

DFSDM #79

wants to merge 1 commit into from

Conversation

richardeoin
Copy link
Member

Beginning of DFSDM support. Needs work in upstream PAC crate first, register addresses from SVD are incorrect.

@bors bors bot closed this Jan 31, 2021
@bors bors bot deleted the branch stm32-rs:master January 31, 2021 20:07
@richardeoin richardeoin reopened this Jan 31, 2021
@richardeoin
Copy link
Member Author

Reopened after it was closed by an errant bors

@David-OConnor
Copy link

Hi. I just implemented DFSDM, and am getting ready to test it on H7 (https://github.com/David-OConnor/stm32-hal/blob/main/src/dfsdm.rs)

Which PAC fields are incorrect? Are they still incorrect?

@mattico
Copy link
Contributor

mattico commented Oct 2, 2021

@David-OConnor neat, I'm glad someone is working on a cross-stm32 HAL (besides embassy). It seemed silly to duplicate all this work when the STM32 chips are similar enough that a lot can be reused.

Looking at the register offsets and §30.8.16 of RM0433 R7, all of the field offsets except for DFSDM_CHCFG0R1 are wrong. Looks like all of the names are wrong, too and some of the fields are missing? Looking at the stm32-rs nightlies this wasn't fixed by the updated SVDs.

image

The registers are grouped by channel. All of the different types of registers for one channel are next to each other. However in the PAC the registers are grouped by type. e.g. all of the DFSDM_CHCFGxR1 registers are one after another in memory.

@David-OConnor
Copy link

Fix inbound stm32-rs/stm32-rs#637

Offsets only appear to be off for H743 and H743V. Fixing reg names across H7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants