Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code incorrectly removed in commit #2094

Closed
luke-adnav opened this issue Aug 7, 2023 · 1 comment · Fixed by #2095
Closed

Code incorrectly removed in commit #2094

luke-adnav opened this issue Aug 7, 2023 · 1 comment · Fixed by #2095
Labels
documentation 📚 Improvements or additions to documentation
Milestone
2.7.0

Comments

@luke-adnav
Copy link

I believe these 2 lines of code were incorrectly removed in the latest commit to the file:

0288818#diff-f6b769f7b8597c3a03918579e5024885874caf2aa65259a76f8d80a5a2ff11e5L67-L68

Arduino_Core_STM32/system/STM32H7xx/system_stm32h7xx.c

Lines 67 to 68 in 1559816

/*!< Uncomment the following line if you need to use initialized data in D2 domain SRAM (AHB SRAM) */
/* #define DATA_IN_D2_SRAM */

fpistm added a commit to fpistm/Arduino_Core_STM32 that referenced this issue Aug 7, 2023
@fpistm
fix(H7): restore DATA_IN_D2_SRAM comment in system source file
32816e1 
Fixes stm32duino#2094

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm mentioned this issue Aug 7, 2023
Merged
@fpistm fpistm added the documentation 📚 Improvements or additions to documentation label Aug 7, 2023
@fpistm fpistm added this to the 2.7.0 milestone Aug 7, 2023
@fpistm
Copy link
Member

fpistm commented Aug 7, 2023

Hi @luke-adnav
Thanks for pointing this. I've restored the 2 lines thanks #2095

fpistm added a commit that referenced this issue Aug 9, 2023
@fpistm
fix(H7): restore DATA_IN_D2_SRAM comment in system source file
c19744c 
Fixes #2094

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation 📚 Improvements or additions to documentation
Projects
None yet
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

fix(H7): restore DATA_IN_D2_SRAM comment in system source file fpistm/Arduino_Core_STM32
2 participants
@fpistm @luke-adnav