Patch sm #1519
Merged
Patch sm #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @beserge |
|
@fpistm The hardware is finalized, so the pinout won't change. Do you have any advice for setting up those Analog Pins I mentioned? |
|
I wiil check deeply on monday. the PIN_Ax defined in the .h should match in the analogInputPin[] of the .c: |
|
@fpistm I was able to get them working, thanks for the help! |
fpistm
reviewed
Oct 25, 2021
Closed
fpistm
requested changes
Oct 27, 2021
Create variant .h .cpp and pinperiphs.c files Use daisy seed linker script for patch sm Add variant to boards.txt Add Patch SM with link to README.md
fpistm
approved these changes
Oct 27, 2021
|
Everything checks out on our end. OK to merge. Thanks for all the thorough reviews. |
Welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes/implements the following bugs/features
This PR adds the Daisy Patch SM as a variant.
The Patch SM is an upcoming hardware platform from Electrosmith following in the footsteps of the Daisy Seed.
The one thing we might want to change is the ordering of the Analog pins (A0, A1, etc).
We tried simply reordering the
analogInputPinarray, which worked for some pins, but eventually just broke.