Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HardwareTimer: Add API to check whether timer/channels are running #1550

Merged
merged 1 commit into from
Nov 19, 2021
Merged

HardwareTimer: Add API to check whether timer/channels are running #1550

merged 1 commit into from
Nov 19, 2021

Conversation

ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Nov 18, 2021

Summary
HardwareTimer: Add API to check whether timer/channels are running

  • bool isRunning(); //returns true if HardwareTimer is running
  • bool isRunningChannel(channel); //returns true if channel is running

Fixes #1525

@ABOSTM ABOSTM added the enhancement New feature or request label Nov 18, 2021
@ABOSTM ABOSTM mentioned this pull request Nov 18, 2021
Closed
fpistm
fpistm requested changes Nov 18, 2021
View reviewed changes
cores/arduino/HardwareTimer.h Outdated Show resolved Hide resolved
@ABOSTM ABOSTM force-pushed the HT_API_RUNNING_TIMER_CHANNEL branch from 0fa4e98 to 46dbaf2 Compare November 18, 2021 13:06
fpistm
fpistm requested changes Nov 18, 2021
View reviewed changes
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😉

cores/arduino/HardwareTimer.h Outdated Show resolved Hide resolved
@ABOSTM
HardwareTimer: Add API to check whether timer/channels are running
65dbc42 
* bool isRunning(); //return true if HardwareTimer is running
* bool isRunningChannel(channel); //return true if channel is running

Fixes stm32duino#1525

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM ABOSTM force-pushed the HT_API_RUNNING_TIMER_CHANNEL branch from 46dbaf2 to 65dbc42 Compare November 18, 2021 13:49
@fpistm fpistm merged commit d217150 into stm32duino:main Nov 19, 2021
@fpistm
Copy link
Member

fpistm commented Nov 19, 2021

Thank you @ABOSTM

@fpistm fpistm mentioned this pull request Nov 23, 2021
Closed
ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this pull request Nov 23, 2021
@ABOSTM
HardwareTimer: remove useless variable timAssociatedInputChannel
7e26aa4 
Compilation warning introduced by stm32duino#1550
Fixes stm32duino#1557

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM ABOSTM mentioned this pull request Nov 23, 2021
Merged
ABOSTM added a commit to ABOSTM/Arduino_Core_STM32 that referenced this pull request Nov 23, 2021
@ABOSTM
HardwareTimer: Fix compilation warning introduced by stm32duino#1550
528bf56 
Fixes stm32duino#1557

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
fpistm pushed a commit that referenced this pull request Nov 23, 2021
@ABOSTM @fpistm
HardwareTimer: Fix compilation warning introduced by #1550
975da6c 
Fixes #1557

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpistm fpistm fpistm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HardwareTimer lacks a function to check if it's running or not
2 participants
@ABOSTM @fpistm