-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variant for Daisy Petal SM #1559
Conversation
Hi @beserge |
Hi @fpistm That's correct, since releases don't happen all too often, we figured we'd get the next variant added now in hopes of catching the 2.2.0 release. We've done a cursory test that works on the prototype hardware, and can do any cleanup early next week. Do you have a release schedule somewhere (on github, the forum, or elsewhere), or at least an idea of when you're planning on doing the next release? We will probably have a few more electro-smith/daisy variants to add throughout next year. So having an idea of the release timeline would be helpful for us to work into our scheduling. Thanks! |
You can check the milestone. As you have more and more boards, maybe it would be fine to add a dedicated menu named "ElectroSmith" ? |
Still TODO: update the readme with the new variant linked to the ES site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@fpistm I didn't realize the milestone had a date. That's helpful. Thanks! And that sounds good. We can move the boards to a single Electrosmith menu next year when we add the new boards we'll be working on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @beserge
Please, Could you rebase on top of the main?
There is a merge conflict with boards.txt due to the DevEBoxH7 addition.
Hi @beserge and @stephenhensley Could you give me a new link or I simply redirect to https://www.electro-smith.com ? |
Hi @fpistm, That link is the correct URL. That particular board is still not available for purchase. So the link was disabled on the site. Thanks for checking. |
Hi @stephenhensley |
This PR fixes/implements the following bugs/features
Add Daisy Petal SM variant
This PR adds the Daisy Petal SM as a variant.
The Petal SM is an upcoming hardware platform from Electrosmith following in the footsteps of the Daisy Seed.