-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new Agafia SG0 Board #1690
Conversation
AGAFIA SG0 board is based on STM32G071CB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harji2130
Thank you for your contribution and Well formed PR.
CI will be launched when you will update your PR based on our comments.
variants/STM32G0xx/G071C(6-8-B)(T-U)_G081CB(T-U)/variant_agafia_sg0.h
Outdated
Show resolved
Hide resolved
variants/STM32G0xx/G071C(6-8-B)(T-U)_G081CB(T-U)/variant_agafia_sg0.h
Outdated
Show resolved
Hide resolved
variants/STM32G0xx/G071C(6-8-B)(T-U)_G081CB(T-U)/variant_agafia_sg0.h
Outdated
Show resolved
Hide resolved
variants/STM32G0xx/G071C(6-8-B)(T-U)_G081CB(T-U)/variant_agafia_sg0.h
Outdated
Show resolved
Hide resolved
Hi @harji2130 |
Hi @fpistm, I will have the changes updated by mid of next week. |
OK @harji2130. Thank you for the update. No problem. |
c44c60e
to
4171f79
Compare
Hi @fpistm, I have made the changes as per your suggestions. |
- Correct case sensitive issue with filename - Add linker script - Add missing ALTx pin declaration - apply astyle - some clean up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @harji2130
I've corrected several things, please refers to the PR I had submitted here:
SigmaIC#1
If yo merge it it will update this PR.
fix: variant declaration
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fix(agafia): linker script typo
Since stm32duino#1690, generic should be added Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
* Added new Agafia SG0 Board AGAFIA SG0 board is based on STM32G071CB Signed-off-by: arsimranjit Sindhar <harsimransindhar@gmail.com> Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Since stm32duino#1690, generic should be added Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
AGAFIA SG0 is the custom board based on STM32G071CB.
This PR fixes/implements the following bugs/features