Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added F722RE Variant to boards.txt, added F722RE ldscript.ld #1712

Merged
merged 3 commits into from
May 31, 2022
Merged

Added F722RE Variant to boards.txt, added F722RE ldscript.ld #1712

merged 3 commits into from
May 31, 2022

Conversation

geosmall
Copy link
Contributor

@geosmall geosmall commented May 8, 2022

No description provided.

@geosmall
Copy link
Contributor Author

geosmall commented May 8, 2022

Add F722RE variant

@geosmall geosmall closed this May 8, 2022
@geosmall geosmall reopened this May 8, 2022
@geosmall
Copy link
Contributor Author

geosmall commented May 8, 2022

Try again to add F722RE variant

@fpistm fpistm added the new variant Add support of new bard label May 9, 2022
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @geosmall
Thanks for the PR.
Could you add the 3 other mcu boards entries int the boards.txt?
It misses also the update of the README.md.

I guess it should be fine to add a default system core clock config to ensure USB clock is correctly set to 48 MHz in

#warning "SystemClock_Config() is empty. Default clock at reset is used."

boards.txt Show resolved Hide resolved
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
Copy link
Member

fpistm commented May 30, 2022

README.md will be updated later else it will add merge conflict:

+| :yellow_heart: | STM32F722RC<br>STM32F722RE | Generic Board | **2.3.0** |  |
+| :yellow_heart: | STM32F730R8<br>STM32F732RE | Generic Board | **2.3.0** |  |

@fpistm fpistm merged commit e2f8bc3 into stm32duino:main May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants