Fix for ADC timing for NUCLEO-WL55JC (STM32WLxx) #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
approved these changes
Jul 20, 2022
|
Hi @yourapiexpert |
fpistm
added a commit
that referenced
this pull request
Jul 21, 2022
Complete the PR #1766 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
cparata
pushed a commit
to cparata/Arduino_Core_STM32
that referenced
this pull request
Jan 31, 2023
Complete the PR stm32duino#1766 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes/implements the following bugs/features
Motivation
When using the STM32Examples (internal channels) sketch to read the internal ADC values from the NUCLEO-WL55JC (STM32WLxx) the following is observed:
VRef(mv)= 3223 Temp(°C)= -92 Vbat(mv)= 598 A0(mv)= 0
VRef(mv)= 3274 Temp(°C)= -88 Vbat(mv)= 606 A0(mv)= 0
VRef(mv)= 3223 Temp(°C)= -91 Vbat(mv)= 597 A0(mv)= 0
Note that VRef is a little on the low side for USB power and that Temp provides an implausible and erroneous negative number. Vbat is also somewhat questionable.
With the small fix applied the following is observed:
VRef(mv)= 3308 Temp(°C)= 28 Vbat(mv)= 1109 A0(mv)= 0
VRef(mv)= 3310 Temp(°C)= 28 Vbat(mv)= 1110 A0(mv)= 0
VRef(mv)= 3313 Temp(°C)= 29 Vbat(mv)= 1110 A0(mv)= 0
Note that VRef reads more or less correct and that Temp presents a value more aligned with ambient room temperature. Vbat also appears more realistic.
Validation