Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nucleo F722ZE board #1831

Merged
merged 2 commits into from
Sep 16, 2022
Merged

Conversation

gautierg-st
Copy link
Contributor

Fixes #1259

Tested:

  • Serial
  • USB
  • I2C
  • SPI

@fpistm fpistm self-requested a review September 16, 2022 09:32
@fpistm fpistm added the new variant Add support of new bard label Sep 16, 2022
@fpistm fpistm added this to the 2.4.0 milestone Sep 16, 2022
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first PR. Somes minor remarks.
Anyway it misses the generic declaration.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It misses generic references in the README.md and the generic clock to add in the generic_clock.c (ex: https://github.com/stm32duino/Arduino_Core_STM32/pull/1712/files#diff-9c22d2f9bf0c6ada5a16b60c5dee88c8c2a5dbe87159623aea7fb4c3215dc56eL24)

Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round 😉
Else LGTM. Thanks.

README.md Outdated Show resolved Hide resolved
variants/STM32F7xx/F722Z(C-E)T_F732ZET/generic_clock.c Outdated Show resolved Hide resolved
Add the following generic variants:
- STM32F722ZCTx
- STM32F722ZETx
- STM32F732ZETx
Fixes stm32duino#1259

Tested:
- Serial
- USB
- I2C
- SPI
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit 7a9b96d into stm32duino:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nucleo 144 F722ZE
3 participants