-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nucleo F722ZE board #1831
Add Nucleo F722ZE board #1831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice first PR. Somes minor remarks.
Anyway it misses the generic declaration.
8799aa9
to
6de723b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It misses generic references in the README.md and the generic clock to add in the generic_clock.c
(ex: https://github.com/stm32duino/Arduino_Core_STM32/pull/1712/files#diff-9c22d2f9bf0c6ada5a16b60c5dee88c8c2a5dbe87159623aea7fb4c3215dc56eL24)
6de723b
to
03dd1e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round 😉
Else LGTM. Thanks.
Add the following generic variants: - STM32F722ZCTx - STM32F722ZETx - STM32F732ZETx
Fixes stm32duino#1259 Tested: - Serial - USB - I2C - SPI
2313e29
to
a855f12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1259
Tested: