Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links for "WeAct MiniSTM32H7*" boards #1934

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Fix links for "WeAct MiniSTM32H7*" boards #1934

merged 1 commit into from
Jan 28, 2023

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jan 28, 2023

Pull Request template

Summary

Fix useless, confusing, and potentially malicious links for "WeAct MiniSTM32H7*" boards.

CC: @ag88

This PR fixes/implements the following bugs/features

  • Fix useless, confusing, and potentially malicious links for "WeAct MiniSTM32H7*" boards
  • Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

The previous links lead through a GitHub username change redirect to a repository that appears to be used to demonstrate a security vulnerability.

I replaced them with links to the repo under the WeActStudio GitHub account which actually contains information about the hardware. The other links for WeAct hardware in the readme are under that GitHub and the product listings under the "WeAct Studio Official Store" on AliExpress.

Validation

  1. Open the previous link:
    https://github.com/WeActTC/MiniSTM32H7xx
  2. Note that there is no useful information there.
  3. Note that the readme contains a link to a dependency, which is then explained to be a PoC placeholder for malware.
  4. Consider that a user visiting this link to get information about the board would only be confused and distressed by what they found there.
  5. Open the replacement link:
    https://github.com/WeActStudio/MiniSTM32H7xx
  6. Note that there is useful information.
  7. Open the "Official WeAct Studio Store" page on Aliexpress:
    https://weactstudio.aliexpress.com/store/1101545918
  8. Find the listing for the STM32H750VBT6 dev board.
  9. Note that the listing text contains https://github.com/WeActStudio/MiniSTM32H7xx

Code formatting

  • Ensure AStyle check is passed thanks CI

N/A

Closing issues

None

The previous links lead through a GitHub username change redirect to a repository that appears to be used to demonstrate a security vulnerability.

I replaced them with links to the repo under the WeActStudio GitHub account which actually contains information about the hardware. The other links for WeAct hardware in the readme are under that GitHub and the product listings under the "WeAct Studio Official Store" on AliExpress.
@fpistm
Copy link
Member

fpistm commented Jan 28, 2023

Thanks @per1234
I've corrected the same for F4 Mini but missed this one.

@fpistm fpistm merged commit 1357c08 into stm32duino:main Jan 28, 2023
@ag88
Copy link
Contributor

ag88 commented Jan 30, 2023

thanks, @per1234 , I did not realized the old repository has changed without notice and replaced with possibly malware.
notice that there is a redirect to a different repository which was originally addressed as WeActTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants