Add MicroMod STM32WB5MMG. Move MicroMod STM32F405 under SparkFun Boards file. #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing Pin C13. Set correct UART TX/RX. Add LPUART. Re-add ifdef guards for TIM. Add Serial Hardware Open
Bring boards.txt file changes to current release standards. Move F405 MMPB to SFE category in boards.txt. Update README.md for SFE boards. Ran cmake_updater_hook.py only allowing changes that affect SFE products Added STM32WB5MMG MMPB to platformio boards_remap.json
fpistm
requested changes
Jun 8, 2023
There was a problem hiding this comment.
Hi @SFE-Brudnerd
Thanks for this PR.
You can find here my first remarks about this PR. I will deeply check later.
Co-authored-by: Frederic Pillon <frederic.pillon@st.com> Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
|
Hey @fpistm, when I was running the arduino-cli workflow, I received this error, from what I'm reading this is an issue outside of the changes I've made. Is this expected? |
|
No. It seems your changes brings issue with {} issue. Will check that. |
Add space to ToC that was mistakenly removed. Readded pipe that was mistakenly removed.
|
Let's CI run to have a first result. 😉 |
fpistm
requested changes
Jun 9, 2023
variants/STM32WBxx/WB5MMGH/PeripheralPins_SFE_MMPB_STM32WB5MMG.c
Outdated
Show resolved
Hide resolved
Co-authored-by: Frederic Pillon <frederic.pillon@st.com> Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com> Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com> Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
Co-authored-by: Frederic Pillon <frederic.pillon@st.com> Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
fpistm
requested changes
Jun 9, 2023
|
You didn't try to build before? So you didn't make any tests with the board? |
|
I did a fair bit of testing before I pulled the upstream in, I realized that I didn't test afterwards. |
fpistm
requested changes
Jun 12, 2023
Co-authored-by: Frederic Pillon <frederic.pillon@st.com> Signed-off-by: Alex Brudner <101155592+SFE-Brudnerd@users.noreply.github.com>
fpistm
approved these changes
Jun 14, 2023
fpistm
requested changes
Jun 14, 2023
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm
approved these changes
Jun 14, 2023
|
@SFE-Brudnerd |
|
Works for me, thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds the MicroMod Processor Board - STM32WB5MMG board files.
Consolidates the SparkFun STM32 products under one menu.
This PR fixes/implements the following features
Explain the motivation for making this change. What existing problem does the pull request solve?
The motivation of the change is to add Arduino support for an upcoming board release.
Validation
Code formatting