Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variants(C0): add generic C011D6, C011F(4-6)(P-U) and C031F(4-6)P #2048

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jun 29, 2023

Base for #1995.

/CC @honnet

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm added the new variant Add support of new bard label Jun 29, 2023
@fpistm fpistm added this to the 2.6.0 milestone Jun 29, 2023
@fpistm fpistm merged commit 292819f into stm32duino:main Jun 29, 2023
@fpistm fpistm deleted the STM32C011D6 branch June 29, 2023 13:29
@honnet
Copy link
Contributor

honnet commented Jun 30, 2023

Very cool!
Now I understand better what was wrong in my original pull request, hopefully it will help me improve my future PRs, thanks a lot!


PS: There's a last question if I may:

I had to remove the "WEAK" attribute for SystemClock_Config(), otherwise some of these parameters* were overwritten.

=> Could it be because it was (incorrectly) in variant_generic.cpp instead of generic_clock.c?

*I think it was the Clock source or pre-scaler.

@fpistm
Copy link
Member Author

fpistm commented Jun 30, 2023

The function have to be WEAK to be able to overwrite it at sketch level that's all.

@honnet
Copy link
Contributor

honnet commented Jun 30, 2023

OK! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants