Skip to content

Conversation

dojyorin
Copy link
Contributor

@dojyorin dojyorin commented Jul 6, 2024

I'm sorry for inconvenience caused with PR:Nucleo-H503RB.
Could you please make sure added and modified code?

I set clock configuration in STM32CubeMX as described on Wiki, but peripheral configuration were not present in code.
(e.g. PeriphClkInitStruct.UsbClockSelection = RCC_USBCLKSOURCE_HSI48)
Looking at CubeMX clock configuration GUI, for example, USB uses HSI48 by default, so does that mean no additional configurations are required?

Summary

This PR implements the following features

  • New variant: Generic STM32H503KBU

* add board definition.

* copy ldscript.

* change name.

* copy clock config.

* add generic clock.

* variable size.

* add support list.
@dojyorin dojyorin changed the title Add variant: H503KBU Add variant: Generic H503KBU Jul 6, 2024
@fpistm fpistm added the new variant Add support of new bard label Jul 8, 2024
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo to fix and it is ok for me.
About Periphjeral clock config, no need to specify it as HSI48 is the default entry.

Accept version fix.

Co-authored-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Kazuki Ota <ota_droid@live.jp>
@dojyorin
Copy link
Contributor Author

dojyorin commented Jul 8, 2024

About Periphjeral clock config, no need to specify it as HSI48 is the default entry.

Thank you for teaching me.
Version fix suggestion was accepted.

@dojyorin dojyorin requested a review from fpistm July 8, 2024 17:58
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added this to the 2.8.1 milestone Jul 9, 2024
@fpistm fpistm merged commit 0f1ee4d into stm32duino:main Jul 9, 2024
@dojyorin dojyorin deleted the variant-h503kbu branch July 10, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new variant Add support of new bard

Projects

Development

Successfully merging this pull request may close these issues.

2 participants