Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic L431C(B-C)(T-U) Variant #2427

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Generic L431C(B-C)(T-U) Variant #2427

merged 7 commits into from
Jul 15, 2024

Conversation

jordancormack
Copy link
Contributor

Adding generic L431C(B-C)(T-U) board variants.

I followed the wiki guide, but this is the first new variant I've added, so hopefully I have done everything correctly!

@fpistm fpistm added the new variant Add support of new bard label Jul 9, 2024
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes to do and it will be ok for merge. Thanks.

variants/STM32L4xx/L431C(B-C)(T-U)/generic_clock.c Outdated Show resolved Hide resolved
variants/STM32L4xx/L431C(B-C)(T-U)/generic_clock.c Outdated Show resolved Hide resolved
variants/STM32L4xx/L431C(B-C)(T-U)/generic_clock.c Outdated Show resolved Hide resolved
boards.txt Outdated Show resolved Hide resolved
variants/STM32L4xx/L431C(B-C)(T-U)/generic_clock.c Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm added this to the 2.8.1 milestone Jul 9, 2024
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@jordancormack
Copy link
Contributor Author

@fpistm anything else I need to do for this?

@fpistm fpistm self-requested a review July 12, 2024 15:23
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm merged commit 8ab4da9 into stm32duino:main Jul 15, 2024
24 checks passed
@fpistm
Copy link
Member

fpistm commented Jul 15, 2024

@fpistm anything else I need to do for this?

All is fine. I was OOO the last 4 days. 😉 Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new variant Add support of new bard
Projects
Development

Successfully merging this pull request may close these issues.

2 participants