-
Notifications
You must be signed in to change notification settings - Fork 981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add variant NUCLEO-C071RB #2558
Conversation
@fpistm I have NO idea if this is correct. I could not find any guideline on how to do for Nucleos. I took a look at https://github.com/stm32duino/Arduino_Core_STM32/pull/1745/files when doign this. It seems I should have done changes in the variant_NUCLEO_C071RB.cpp and variant_NUCLEO_C071RB.h files in some way, that I probably got wrong. I am completely ok with you updating anything in this commit manually. I have no idea how to test it. |
Hi @thernstig |
4d84152
to
330e6ae
Compare
@fpistm Rebase done. Are any updates needed in the .cpp and .h file? I have no idea what is needed there. |
@thernstig |
330e6ae
to
6ef59d1
Compare
@thernstig
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes stm32duino#2537 Signed-off-by: thernstig <30827238+thernstig@users.noreply.github.com>
See STMicroelectronics/stm32c0xx-hal-driver#1 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
6ef59d1
to
deaab3c
Compare
@fpistm thank you! If you think this looks ok I am ok to merge as well 🙂 Are you intending to release 2.9.0 soon 😄 |
Yes, in the coming days, anyway think that I've not tested this PR as I do not have the board. Anyway, I'm confident that it should work. Only a doubt about USB as it is the first time deployed on STM32C0xx series. |
Fixes #2537