fix(hardwaretimer): avoid glitch when PWM configuration changed #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As all get API's use error handler if an error occur, then no need to use int as return type. Moreover, all HAL API uses uint32_t for those value. This avoid cast issue. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
to avoid confusion. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Allow to properly set handle state. Start TIM base only if required. Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Fixes stm32duino#2575. Note that the issue is that TIM_OCx_SetConfig() disable in unconditionally the N state output (TIM_CCER_CCxNE). Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm
changed the title
fpistm
added a commit
to fpistm/STM32Examples
that referenced
this pull request
Nov 21, 2024
TIMER_DISABLED replaced by TIMER_OUTPUT_DISABLED See stm32duino/Arduino_Core_STM32#2572 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
fpistm
added a commit
to stm32duino/STM32Examples
that referenced
this pull request
Nov 21, 2024
TIMER_DISABLED replaced by TIMER_OUTPUT_DISABLED See stm32duino/Arduino_Core_STM32#2572 Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2575
issue is that
TIM_OCx_SetConfig()disable unconditionally the N state output (TIM_CCER_CCxNE), preventing tocall
setMode()fix the issue and avoid glitch.Note
This PR include some hardening and enhancement.
TIMER_DISABLEDtoTIMER_OUTPUT_DISABLED