Avoid I2C timing computation when input clock is unchanged #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpistm
requested changes
Sep 11, 2019
There was a problem hiding this comment.
Some minor changes else LGTM.
- one astyle issue:
- if ((I2C_ClockTiming[i2c_speed].input_clock == clkSrcFreq) &&(I2C_ClockTiming[i2c_speed].timing != 0U)) {
+ if ((I2C_ClockTiming[i2c_speed].input_clock == clkSrcFreq) && (I2C_ClockTiming[i2c_speed].timing != 0U)) {
ABOSTM
force-pushed
the
AVOID_I2C_TIMING_COMPUTATION
branch
from
60f7d05 to
30bc2fc
Compare
With U8g2 library, I2C clock is set for each transmission. With some I2C harwdware version, timings are then computed for each time. This cause very slow display on LCD.
ABOSTM
force-pushed
the
AVOID_I2C_TIMING_COMPUTATION
branch
from
30bc2fc to
8087d8d
Compare
fpistm
requested changes
Sep 12, 2019
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
fpistm
requested changes
Sep 12, 2019
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
Co-Authored-By: Frederic Pillon <frederic.pillon@st.com>
fpistm
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With U8g2 library, I2C clock is set for each transmission.
With some I2C harwdware version,
timings are then computed for each time.
This cause very slow display on LCD.
This PR saves computed I2C timing and reuses those timing if I2C input clock is the same.
This Fixes issue found by @jmchiappa in PR #590