Skip to content

Conversation

@Jozo132
Copy link

@Jozo132 Jozo132 commented Dec 4, 2019

Added a new board to dropdown menu based on existing variant.
This is no breaking change.
Bugs are probably hiding somewhere because we are referencing a slightly different variant with the same layout to support this board.
Tests need to be done to see if everything is compatible.

I own two BlackPills F401CC and F411CE, both on the same PCB.
AliExpress link: https://www.aliexpress.com/item/4000069263843.html
The only difference seems to be 256K Flash + 64K RAM versus 512K Flash + 128K RAM.
Compiles, uploads and works for me over DFU with serial out.

Tests need to be done to see if everything is compatible.

I own two BlackPills F401CC and F411CE, both on the same PCB.
AliExpress link: https://www.aliexpress.com/item/4000069263843.html
The only difference seems to be 256K Flash + 64K RAM versus 512K Flash + 128K RAM.
Compiles, uploads and works for me over DFU with serial out.
@fpistm fpistm added the new variant Add support of new bard label Dec 5, 2019
@fpistm
Copy link
Member

fpistm commented Dec 5, 2019

Hi @Jozo132
Thanks for this PR

Tests need to be done to see if everything is compatible.

Let me know if all is OK.
Maybe variant folder could be renamed to be more generic to avoid any confusion.

@fpistm fpistm added the abandoned No more work on this label Feb 3, 2020
@fpistm
Copy link
Member

fpistm commented Feb 3, 2020

Hi @Jozo132
I will not merge this PR.
The variant for this board will use the Generic variant definition.

@fpistm fpistm closed this Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abandoned No more work on this new variant Add support of new bard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants