Skip to content

Conversation

@ABOSTM
Copy link
Contributor

@ABOSTM ABOSTM commented Aug 23, 2022

fix(ExternalWakeup): customization may be needed depending on button implementation

Warning: depending on boards, and its button hardware implementation,
it may be required to adapt INPUT_PULLUP/INPUT_PULLDOWN parameter
in pinMode(pin, XXX)

…implementation

Warning: depending on boards, and its button hardware implementation,
it may be required to adapt INPUT_PULLUP/INPUT_PULLDOWN parameter
in pinMode(pin, XXX)

Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
@ABOSTM ABOSTM requested a review from fpistm August 23, 2022 16:05
Copy link
Member

@fpistm fpistm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm added the enhancement New feature or request label Aug 23, 2022
@fpistm fpistm added this to the 1.2.1/1.3.0 milestone Aug 23, 2022
@fpistm fpistm merged commit 1a17d41 into stm32duino:main Aug 23, 2022
@ABOSTM ABOSTM mentioned this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants