Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add second alarm (B) support #86

Merged
merged 7 commits into from
Jan 18, 2023
Merged

feat: add second alarm (B) support #86

merged 7 commits into from
Jan 18, 2023

Conversation

fpistm
Copy link
Member

@fpistm fpistm commented Jan 13, 2023 •
edited
Loading

Supersede #75

Fixes #74

Test

  • STM32F0
  • STM32F1
  • STM32F2
  • STM32F3
  • STM32F4
  • STM32F7
  • STM32G0
  • STM32G4
  • STM32H7
  • STM32L0
  • STM32L1
  • STM32L4
  • STM32L5
  • STM32U5
  • STM32WB
  • STM32WL

Sketch used to test added to the examples folder: RTCReset.ino

@fpistm fpistm added the enhancement New feature or request label Jan 13, 2023
@fpistm fpistm added this to the 1.3.5 milestone Jan 13, 2023
@fpistm fpistm marked this pull request as draft January 13, 2023 16:38
This was referenced Jan 13, 2023
Closed
Closed
@fpistm
chore(keywords): add missing items
718e96a 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm force-pushed the AlarmAB branch 4 times, most recently from 30dedc9 to 0b2012e Compare January 15, 2023 11:15
@fpistm fpistm marked this pull request as ready for review January 15, 2023 11:15
@fpistm fpistm force-pushed the AlarmAB branch 2 times, most recently from 68fbd74 to f8e9bb7 Compare January 17, 2023 10:24
@fpistm fpistm requested a review from ABOSTM January 17, 2023 10:25
ABOSTM
ABOSTM reviewed Jan 17, 2023
View reviewed changes
ABOSTM
ABOSTM approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@ABOSTM ABOSTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fpistm fpistm force-pushed the AlarmAB branch 5 times, most recently from d90b769 to afaf522 Compare January 18, 2023 17:43
fpistm and others added 6 commits January 18, 2023 18:53
@fpistm @batkov
feat: add second alarm (B) support
d5484bb 
Fixes stm32duino#74

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
Co-authored-by: hariton_batkov <yanker90@gmail.com>
@fpistm
feat: add getAlarmEpoch method
74e2b17 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
fix: restore default alarm values if valid
ead6df5 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
fix(examples): use RTC_SSR_SS for subsecond management
d7ea564 
STM32F2xx also have no subsecond

Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
chore: include time.h within STM32RTC.h
47631ef 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm
chore(examples): add RTCReset
5fcb571 
Signed-off-by: Frederic Pillon <frederic.pillon@st.com>
@fpistm fpistm merged commit ad158d3 into stm32duino:main Jan 18, 2023
@fpistm fpistm deleted the AlarmAB branch January 18, 2023 23:16
@fpistm fpistm mentioned this pull request Jun 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ABOSTM ABOSTM ABOSTM approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.3.5
Development

Successfully merging this pull request may close these issues.

Add simultaneous support for RTC_ALARM_A and RTC_ALARM_B
2 participants
@fpistm @ABOSTM