fix: increase typing timeout to 4s #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The frontend only sends typing updates every 2.5-3s, so the 1s timeout caused the typing indicator to flicker. Signed-off-by: Aeledfyr <aeledfyr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The frontend only sends typing updates every 2.5-3s, so the 1s timeout caused the typing indicator to flicker.
Note that the typing indicators still have some flickering, but it should only be when the user's client sent a StopTyping event, so the source of the flicker is in the sender's typing detection heuristics.
(Given the timeout, I'm not sure if StopTyping events are necessary before a message is actually sent -- would it be simpler to have CurrentlyTyping events with a timeout, and cancel the indicator on the next received message from that user?)
Please make sure to check the following tasks before opening and submitting a PR