Remove hub-template error handling

The framework-addon now handles emitting compliance events for those
errors for all template policy types.

Refs:
 - https://issues.redhat.com/browse/ACM-10858

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>

controllers/configurationpolicy_controller.go

@@ -971,28 +971,6 @@ func (r *ConfigurationPolicyReconciler) handleObjectTemplates(plc policyv1.Confi
 
 		// process object templates for go template usage
 		for i, rawData := range rawDataList {
-			// first check to make sure there are no hub-templates with delimiter - {{hub
-			// if one exists, it means the template resolution on the hub did not succeed.
-			if templates.HasTemplate(rawData, "{{hub", false) {
-				// check to see there is an annotation set to the hub error msg,
-				// if not ,set a generic msg
-				hubTemplatesErrMsg, ok := annotations["policy.open-cluster-management.io/hub-templates-error"]
-				if !ok || hubTemplatesErrMsg == "" {
-					// set a generic msg
-					hubTemplatesErrMsg = "Error occurred while processing hub-templates, " +
-						"check the policy events for more details."
-				}
-
-				log.Info(
-					"An error occurred while processing hub-templates on the Hub cluster. Cannot process the policy.",
-					"message", hubTemplatesErrMsg,
-				)
-
-				addTemplateErrorViolation("Error processing hub templates", hubTemplatesErrMsg)
-
-				return
-			}
-
 			if templates.HasTemplate(rawData, "", true) {
 				log.V(1).Info("Processing policy templates")
 

test/e2e/case13_templatization_test.go

@@ -461,44 +461,6 @@ var _ = Describe("Test templatization", Ordered, func() {
 				return configmap
 			}, defaultTimeoutSeconds, 1).ShouldNot(BeNil())
 
-			By("Patch with invalid hub template")
-			utils.Kubectl("patch", "configurationpolicy", case13PruneTmpErr, "--type=json", "-p",
-				`[{ "op": "replace", 
-			"path": "/spec/object-templates/0/objectDefinition/data/test",
-			 "value": '{{hub "default" "e2esecret" dddddd vvvvv d hub}}' }]`,
-				"-n", testNamespace)
-
-			By("By verifying that the configurationpolicy is NonCompliant")
-			Eventually(func() interface{} {
-				managedPlc := utils.GetWithTimeout(clientManagedDynamic, gvrConfigPolicy,
-					case13PruneTmpErr, testNamespace, true, defaultTimeoutSeconds)
-
-				return utils.GetComplianceState(managedPlc)
-			}, defaultTimeoutSeconds, 1).Should(Equal("NonCompliant"))
-
-			By("By verifying that the configmap still exist ")
-			Consistently(func() interface{} {
-				configmap := utils.GetWithTimeout(clientManagedDynamic, gvrConfigMap,
-					case13PruneTmpErr+"-configmap", "default", true, defaultTimeoutSeconds)
-
-				return configmap
-			}, defaultConsistentlyDuration, 1).ShouldNot(BeNil())
-
-			By("Change to valid configmap")
-			utils.Kubectl("patch", "configurationpolicy", case13PruneTmpErr, "--type=json", "-p",
-				`[{ "op": "replace", 
-				"path": "/spec/object-templates/0/objectDefinition/data/test",
-				 "value": "working" }]`,
-				"-n", testNamespace)
-
-			By("By verifying that the configmap has no error")
-			Eventually(func() interface{} {
-				managedPlc := utils.GetWithTimeout(clientManagedDynamic, gvrConfigPolicy,
-					case13PruneTmpErr, testNamespace, true, defaultTimeoutSeconds)
-
-				return utils.GetComplianceState(managedPlc)
-			}, defaultTimeoutSeconds, 1).Should(Equal("Compliant"))
-
 			By("Patch with invalid managed template")
 			utils.Kubectl("patch", "configurationpolicy", case13PruneTmpErr, "--type=json", "-p",
 				`[{ "op": "replace",