Change undetermined OperatorPolicy names to '-'

Previously they were '*', but '-' might be more familiar to users.

Refs:
 - https://issues.redhat.com/browse/ACM-10202

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit c2a08b8)

api/v1/configurationpolicy_types.go

@@ -328,7 +328,7 @@ type ObjectResource struct {
 func ObjectResourceFromObj(obj client.Object) ObjectResource {
  name := obj.GetName()
  if name == "" {
- name = "*"
+ name = "-"
  }
 
  return ObjectResource{

controllers/operatorpolicy_status.go

@@ -766,7 +766,7 @@ func noInstallPlansObj(namespace string) policyv1.RelatedObject {
  Kind: installPlanGVK.Kind,
  APIVersion: installPlanGVK.GroupVersion().String(),
  Metadata: policyv1.ObjectMetadata{
- Name: "*",
+ Name: "-",
  Namespace: namespace,
  },
  },
@@ -839,7 +839,7 @@ var noExistingCSVObj = policyv1.RelatedObject{
  Kind: clusterServiceVersionGVK.Kind,
  APIVersion: clusterServiceVersionGVK.GroupVersion().String(),
  Metadata: policyv1.ObjectMetadata{
- Name: "*",
+ Name: "-",
  },
  },
  Compliant: string(policyv1.UnknownCompliancy),
@@ -886,7 +886,7 @@ var noExistingDeploymentObj = policyv1.RelatedObject{
  Kind: deploymentGVK.Kind,
  APIVersion: deploymentGVK.GroupVersion().String(),
  Metadata: policyv1.ObjectMetadata{
- Name: "*",
+ Name: "-",
  },
  },
  Compliant: string(policyv1.UnknownCompliancy),

test/e2e/case38_install_operator_test.go

@@ -135,7 +135,7 @@ var _ = Describe("Test installing an operator from OperatorPolicy", Ordered, fun
  Kind: "OperatorGroup",
  APIVersion: "operators.coreos.com/v1",
  Metadata: policyv1.ObjectMetadata{
- Name: "*",
+ Name: "-",
  Namespace: opPolTestNS,
  },
  },
@@ -953,7 +953,7 @@ var _ = Describe("Test installing an operator from OperatorPolicy", Ordered, fun
  APIVersion: "operators.coreos.com/v1alpha1",
  Metadata: policyv1.ObjectMetadata{
  Namespace: opPolTestNS,
- Name: "*",
+ Name: "-",
  },
  },
  Compliant: "Compliant",