🤖 Sync from open-cluster-management-io/config-policy-controller: #300, #301 #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
When a custom mappings file is needed, it is likely needed repeatedly, so requiring it to be set every time when running the command is inconvenient. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 14b1eff0fefd64273c73252d5e10456000c54164)
The command is now correctly marked as a dev preview feature. Errors are now generally wrapped to give some indication of where they came from, and if a resource failed to be applied because of a (likely) missing mapping, the error message now suggests how to fix it. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 9172504cb0aeddf1aa3b8897931f6eceff19a81b)
Refs: - https://issues.redhat.com/browse/ACM-14550 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 58c5e5c314e0ab58809aa16719ba59d3aa5fbcde)
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing the following PRs:
This replaces #1043.