Remove SelfLink #106
Remove SelfLink #106
Conversation
|
Skipping CI for Draft Pull Request. |
|
The self link was originally there so the UI could provide the link in the list of related resources. |
|
The UI constructs a SelfLink for its own uses, so maybe even the UID isn't necessary here? (Though I suppose it helps to have some sort of identifier...I haven't really dug into the code too much beyond replacing the instances with the UID) |
|
@ycao56 What are your thoughts on this? |
|
/hold |
|
I think we can remove it both selflink and uid to see if we need to change the UI. I couldn't remember if we updated the UI or not. |
|
BTW, I don't see selfLink being requested by UI anymore so we must have changed it previously due to ocp47 support |
|
Do we want to remove my implementation of UID also, or is it helpful? I think it could be a simple array of resource names--I'd have to dig into the code a little deeper to be sure. |
|
I think we should completely remove it |
|
Done--ready for review! If these checks pass, I'll update the branch protection rules in |
Fixes error: ``` failed to start the controlplane. retried 5 times: fork/exec /usr/local/kubebuilder/bin/etcd: no such file or directory ``` Reference: operator-framework/operator-sdk#4432 (comment)
|
@dhaiducek also need to update CRD https://github.com/open-cluster-management/config-policy-controller/blob/main/deploy/crds/policy.open-cluster-management.io_configurationpolicies_crd.yaml#L152 |
|
Ah, okay--that's probably the issue I'm running into. Thanks! |
|
I bumped my |
|
can you also generate v1 version and put it in https://github.com/open-cluster-management/config-policy-controller/tree/main/deploy/crds/v1? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, ycao56 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed!
|
|
/unhold |
I wasn't 100% sure why we were using
selfLinkhere, so I've replaced it with the UID since I assumed we wanted some sort of unique identifier. Otherwise, we may need to reconstructselfLinkourselves if we indeed do need it.