Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Sync from open-cluster-management-io/config-policy-controller: #85 #382

Merged
merged 1 commit into from
Dec 6, 2022
Merged

🤖 Sync from open-cluster-management-io/config-policy-controller: #85 #382

merged 1 commit into from
Dec 6, 2022

Conversation

magic-mirror-bot[bot]
Copy link

@JustinKuli
Remove confusing Undetermined compliance state
d35a083 
The situation where this compliance state was being used was appearing
if the ConfigurationPolicy had no templates. Marking it as Unknown is
better, since at least that is a value listed in the api folder...

This change also makes this situation create a compliance event, since
the framework *needs* a new event in all situations when a policy, else
when it transitions from Pending to something else, it will not update.

Refs:
 - https://issues.redhat.com/browse/ACM-2263

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit 423fd34)
@openshift-ci
Copy link

openshift-ci bot commented Dec 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval by writing /assign @mprahl in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@magic-mirror-bot magic-mirror-bot bot merged commit c04ab02 into main Dec 6, 2022
@magic-mirror-bot magic-mirror-bot bot deleted the magic-mirror-main-1670281438091 branch December 6, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JustinKuli