[release-2.6] Fix the conditions history in compliancyDetails #393
Conversation
The status.compliancyDetails[].conditions array was always limited to just a single condition due to a bug. This sets the limit to 10 instead. Relates: https://issues.redhat.com/browse/ACM-2708 Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 0234403)
mprahl
force-pushed
the
fix-conditions
branch
from
a7ab3a2
to
00aac20
Compare
|
Kudos, SonarCloud Quality Gate passed! |
| ) (conditionsRes []policyv1.Condition) { | ||
| defer recoverFlow() |
There was a problem hiding this comment.
I think this looks good! One final thought: @willkutler do you recall why this is here? It was put in 3 years ago, so definitely no worries if you're not sure! fbcef07#diff-abd7bd58ac8e6e13efca328b26418fd3abf28bb9eec7112c669bbfd161e4e950
I want to make sure we're not introducing a panic somewhere, but I also don't recall seeing the "ALERT!" message in any logs...
There was a problem hiding this comment.
I don't unfortunately - some of the code was ported from the old policy controller so Yu might have written that. I haven't seen the ALERT message in any logs either so I think it's fine to remove
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/revert does this work? |
This is a backport of #392 but needed to do it manually due to a test case being slightly different in 2.6.
The status.compliancyDetails[].conditions array was always limited to just a single condition due to a bug. This sets the limit to 10 instead.
Relates:
https://issues.redhat.com/browse/ACM-2708